-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide member mappins on precious plastic #3000
fix: hide member mappins on precious plastic #3000
Conversation
Visit the preview URL for this PR (updated for commit eaffb5b): https://onearmy-next--pr3000-2927-2-hide-member-m-t4pzmo7c.web.app (expires Wed, 27 Dec 2023 22:30:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
I'm getting a different behaviour on the preview branch than locally. Reverting to a draft. |
1 flaky test on run #4623 ↗︎
Details:
src/integration/SignUp.spec.ts • 1 flaky test • ci-firefox
Review all test suite changes for PR #3000 ↗︎ |
Thanks for the try @benfurber. Feel free to leave it for someone else if it gets to complex. Can be challenging with all the instances and configurations |
7da3a15
to
d5bcfbe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3000 +/- ##
==========================================
+ Coverage 56.21% 56.25% +0.03%
==========================================
Files 345 345
Lines 11247 11253 +6
Branches 1934 1940 +6
==========================================
+ Hits 6323 6330 +7
+ Misses 4876 4875 -1
Partials 48 48 ☔ View full report in Codecov by Sentry. |
@davehakkens Thanks for the offer Dave. The issue yesterday was just some incomplete logic I'd written. The behaviour is what is required now, just the issue of checking my new approach to determining PP for production... |
d5bcfbe
to
eaffb5b
Compare
🎉 This PR is included in version 1.127.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Should be released but member pins are still here.. @benfurber |
@davehakkens Next time a build is release can you please check this again? It turns out that |
PR Checklist
PR Type
Description
A more robust attempt at trying to hide member pins by default on PP. This fixes two problems:
I tried first to apply the logic necessary to the display components but I didn't find an approach that worked so I applied it to the store logic instead.
Git Issues
Closes #2927